Allow access to test UART from secure world for QEMU SBSA#227
Allow access to test UART from secure world for QEMU SBSA#227philgweber wants to merge 1 commit intoOpenDevicePartnership:mainfrom
Conversation
| + | ||
| + memory@12 { | ||
| + device_type = "device-memory"; /* UART */ | ||
| + reg = <0x0 0x60130000 0x0 0x00001000>; |
There was a problem hiding this comment.
This is a UART region from a customized QEMU, right? The inbox sbsa does not have this port.
There was a problem hiding this comment.
Also, as we removed the original C secure partition, the 0x60030000 port has no consumers as of today. I was going to switch stmm to use that port. But if you can make better use of 0x60030000, we can leave it mapped for your usage.
There was a problem hiding this comment.
Yeah I had patched QEMU here to exposed a fourth serial port since all the other ones were being used by QEMU. OpenDevicePartnership/odp-qemu-builder@49b63b5
If you are switching StMM to use the secure partition port, I can use the one StMM was using. For extra debug it may still be nice to have another extra port beyond that if we want to leave this one defined.
There was a problem hiding this comment.
I see. I think we can get this in as there is no consumer from this current repo. But let's please add some more comments in the PR description with the QEMU customization link as the firmware will fault if we try to use this region with the in-stock qemu .
6 participants
Description
This change just maps in address range 0x60130000 as valid device memory, so in cases with QEMU where we expose an extra UART for test we can access this memory range from secure world. If UART is not exposed accesses will just fail in QEMU.
This UART is used to map to a physical UART on the computer running QEMU to allow us to attach external test devices for EC and other HW validation.
How This Was Tested
On odp-platform-qemu-sbsa branch with updated qemu from odp-qemu-builder and updated RUST partition to map this region in the DTS, validated that we can read/write data from secure partition over UART as specified.
Integration Instructions
N/A